This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING] [PATCH] [AArch64, NEON] More NEON intrinsics improvement
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: "Yangfei (Felix)" <felix dot yang at huawei dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Zhanghaijian (A)" <z dot zhanghaijian at huawei dot com>, Jiangjiji <jiangjiji at huawei dot com>, Suipengfei <suipengfei at huawei dot com>, Tejas Belagod <tejas dot belagod at arm dot com>
- Date: Fri, 5 Dec 2014 18:49:35 +0000
- Subject: Re: [PING] [PATCH] [AArch64, NEON] More NEON intrinsics improvement
- Authentication-results: sourceware.org; auth=none
- References: <DA41BE1DDCA941489001C7FBD7A8820E837A43E0 at szxema507-mbx dot china dot huawei dot com> <5481FD0C dot 3020500 at arm dot com>
On 5 December 2014 at 18:44, Tejas Belagod <tejas.belagod@arm.com> wrote:
>
>>>
>>> +__extension__ static __inline float32x2_t __attribute__
>>> +((__always_inline__))
>>> +vfms_f32 (float32x2_t __a, float32x2_t __b, float32x2_t __c) {
>>> + return __builtin_aarch64_fmav2sf (-__b, __c, __a); }
>>> +
>>> +__extension__ static __inline float32x4_t __attribute__
>>> +((__always_inline__))
>>> +vfmsq_f32 (float32x4_t __a, float32x4_t __b, float32x4_t __c) {
>>> + return __builtin_aarch64_fmav4sf (-__b, __c, __a); }
>>> +
>>> +__extension__ static __inline float64x2_t __attribute__
>>> +((__always_inline__))
>>> +vfmsq_f64 (float64x2_t __a, float64x2_t __b, float64x2_t __c) {
>>> + return __builtin_aarch64_fmav2df (-__b, __c, __a); }
>>> +
>>> +
>
>
> Thanks, the patch looks good. Just one comment:
> You could also add
> float32x2_t vfms_n_f32(float32x2_t a, float32x2_t b, float32_t n) and its
> Q-variant.
You can, if you wish, deal with Tejas' comment with a follow on patch
rather than re-spinning this one. Provided this patch has no
regressions on a big endian and a little endian test run then you can
commit it.
Thanks
/Marcus