This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [testsuite] Fix multiple definitions of _init
- From: Mike Stump <mikestump at comcast dot net>
- To: Oleg Endo <oleg dot endo at t-online dot de>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 2 Dec 2014 10:23:06 -0800
- Subject: Re: [testsuite] Fix multiple definitions of _init
- Authentication-results: sourceware.org; auth=none
- References: <1417418467 dot 3387 dot 89 dot camel at yam-132-YW-E178-FTW>
On Nov 30, 2014, at 11:21 PM, Oleg Endo <oleg.endo@t-online.de> wrote:
> When running the testsuite on a sh-elf configuration, some test cases
> fail due to multiple definitions of the function '_init'. This is
> because on sh-elf every function is automatically prefixed with a '_'
> char. When defining a C function 'init' in some code, the actual name
> becomes '_init' and this conflicts with the _init function in libgcc
> (crti.S). While the behavior of adding the '_' prefix is debatable, the
> testsuite failures can be easily fixed by the attached patch.
> Is this OK for trunk?
No. It is reasonable for the test suite to fail when the implementation of gcc is wrong (unclean) or newlib startup code is wrong (unclean). Since that is what happened, the fix is to fix the cleanliness problem.
I’ve read through the thread… I think the sh newlib port has a trivial bug and should be fixed. Either, add an underscore or remove one, just like _all_ the other ports. There is no complexity here, just a typo (or someone copied the wrong port).
When newlib/libc/sys/sh/crt0.S is fixed, and libgcc/config/sh/crt1.S is fixed, then these test cases will pass.
USER_LABEL_PREFIX is not the issue. Let me quote from the code:
.long _atexit
.long _init
This is wrong.
Also, _fini needs to be fixed as well. It is unfortunate that the fix involves two packages, but, such is life.