This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Rename gimple_build_assign_with_ops to gimple_build_assign and swap the first two arguments of it
- From: Jakub Jelinek <jakub at redhat dot com>
- To: "Gopalasubramanian, Ganesh" <Ganesh dot Gopalasubramanian at amd dot com>
- Cc: Richard Biener <rguenther at suse dot de>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 2 Dec 2014 08:37:19 +0100
- Subject: Re: [PATCH] Rename gimple_build_assign_with_ops to gimple_build_assign and swap the first two arguments of it
- Authentication-results: sourceware.org; auth=none
- References: <20141201135205 dot GH1892 at tucnak dot redhat dot com> <EB4625145972F94C9680D8CADD65161578EC2A68 at SATLEXDAG02 dot amd dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Dec 02, 2014 at 05:13:52AM +0000, Gopalasubramanian, Ganesh wrote:
> The following patch implements that. Bootstrapped/regtested on x86_64-linux
> and i686-linux, ok for trunk?
>
> Our aarch64 build also breaks as mentioned in https://gcc.gnu.org/ml/gcc-patches/2014-12/msg00119.html
You haven't attached any patch.
Anyway, sorry for missing this, supposedly I've grepped for it in
subdirectories of gcc/ but not in the second level subdirectories.
And, apparently I've missed it also some time ago when removing unnecessary
last NULL arguments too (both for gimple_build_assign_with_ops and
create_tmp_*/*_ssa_name).
I've committed this as obvious:
2014-12-02 Jakub Jelinek <jakub@redhat.com>
* config/alpha/alpha.c (alpha_gimple_fold_builtin): Use
gimple_build_assign instead of gimple_build_assign_with_ops and swap
the order of first two arguments.
* config/aarch64/aarch64-builtins.c (aarch64_gimple_fold_builtin):
Likewise. Remove last NULL_TREE argument.
--- gcc/config/aarch64/aarch64-builtins.c.jj 2014-11-28 14:41:00.000000000 +0100
+++ gcc/config/aarch64/aarch64-builtins.c 2014-12-02 08:17:12.894920620 +0100
@@ -1322,27 +1322,18 @@ aarch64_gimple_fold_builtin (gimple_stmt
switch (fcode)
{
BUILTIN_VALL (UNOP, reduc_plus_scal_, 10)
- new_stmt = gimple_build_assign_with_ops (
- REDUC_PLUS_EXPR,
- gimple_call_lhs (stmt),
- args[0],
- NULL_TREE);
+ new_stmt = gimple_build_assign (gimple_call_lhs (stmt),
+ REDUC_PLUS_EXPR, args[0]);
break;
BUILTIN_VDQIF (UNOP, reduc_smax_scal_, 10)
BUILTIN_VDQ_BHSI (UNOPU, reduc_umax_scal_, 10)
- new_stmt = gimple_build_assign_with_ops (
- REDUC_MAX_EXPR,
- gimple_call_lhs (stmt),
- args[0],
- NULL_TREE);
+ new_stmt = gimple_build_assign (gimple_call_lhs (stmt),
+ REDUC_MAX_EXPR, args[0]);
break;
BUILTIN_VDQIF (UNOP, reduc_smin_scal_, 10)
BUILTIN_VDQ_BHSI (UNOPU, reduc_umin_scal_, 10)
- new_stmt = gimple_build_assign_with_ops (
- REDUC_MIN_EXPR,
- gimple_call_lhs (stmt),
- args[0],
- NULL_TREE);
+ new_stmt = gimple_build_assign (gimple_call_lhs (stmt),
+ REDUC_MIN_EXPR, args[0]);
break;
default:
--- gcc/config/alpha/alpha.c.jj 2014-11-20 17:06:26.000000000 +0100
+++ gcc/config/alpha/alpha.c 2014-12-02 08:18:04.350008413 +0100
@@ -7224,11 +7224,8 @@ alpha_gimple_fold_builtin (gimple_stmt_i
arg0 = gimple_call_arg (stmt, 0);
arg1 = gimple_call_arg (stmt, 1);
- new_stmt
- = gimple_build_assign_with_ops (MULT_HIGHPART_EXPR,
- gimple_call_lhs (stmt),
- arg0,
- arg1);
+ new_stmt = gimple_build_assign (gimple_call_lhs (stmt),
+ MULT_HIGHPART_EXPR, arg0, arg1);
break;
default:
break;
Jakub