This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH v3] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow
- From: Chen Gang <gang dot chen dot 5i5j at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Marek Polacek <polacek at redhat dot com>, Jeff Law <law at redhat dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 27 Nov 2014 07:45:24 +0800
- Subject: Re: [PATCH v3] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow
- Authentication-results: sourceware.org; auth=none
If necessary to add related test case, please let me know.
Thanks.
Send from Lenovo A788t.
Jakub Jelinek <jakub@redhat.com> wrote:
>On Mon, Nov 24, 2014 at 04:28:10PM +0800, Chen Gang wrote:
>> On 11/24/14 15:41, Jakub Jelinek wrote:
>> > On Sun, Nov 23, 2014 at 09:13:27AM +0800, Chen Gang wrote:
>>
>> [...]
>>
>> >> + else
>> >> + pp_wide_int(&pretty_name,
>> >> + wi::add (wi::to_widest (TYPE_MAX_VALUE (dom)), 1),
>> >> + TYPE_SIGN (TREE_TYPE (dom)));
>> >
>> > Space still missing before ( (and reindenting the following 2 lines).
>> >
>>
>> Oh, thanks, if necessary to send patch v4, please let me know.
>
>No, just fix it up before checking in.
>
> Jakub