Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

[Ville Voutilainen <ville dot voutilainen at gmail dot com>]

On 26 November 2014 at 04:42, Jason Merrill <jason@redhat.com> wrote:
> On 11/25/2014 09:41 PM, Jason Merrill wrote:
>>
>> Tested how, exactly?  It doesn't seem to have run old-deja.exp.  I tend

Too hastily, sorry. I managed to notice that the tests adjusted in the patch
failed, and then blissfully didn't look at the further tests.

>> to use the toplevel make-c++ target.
>
>
> Er, check-c++.


Yeah, I ran check-gcc-c++, but conveniently didn't look at the results
thoroughly
enough. New patch attached, tested until the very end including old-deja,
no regressions anymore.

/cp
2014-11-26  Ville Voutilainen  <ville.voutilainen@gmail.com>

    Diagnose string constant conversion to char* in c++11 and above
    as forbidden, not deprecated.
    * typeck.c (string_conv_p): Do a pedwarn in c++11 and above,
    change the diagnostic for the Wwrite-strings case for c++11 and above.

/testsuite
2014-11-26  Ville Voutilainen  <ville.voutilainen@gmail.com>

    Diagnose string constant conversion to char* in c++11 and above
    as forbidden, not deprecated.
    * g++.dg/warn/write-strings-default.C: Adjust.
    * g++.dg/warn/write-strings.C: Likewise.
    * g++.old-deja/g++.bob/inherit1.C: Likewise.
    * g++.old-deja/g++.brendan/template17.C: Likewise.
    * g++.old-deja/g++.law/temps1.C: Likewise.
    * g++.old-deja/g++.martin/typedef2.C: Likewise.

Attachment: string-conversion2.diff
Description: Text document