This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch AArch64] Fix PR 63724 - Improve immediate generation
- From: Marcus Shawcroft <marcus dot shawcroft at gmail dot com>
- To: Ramana Radhakrishnan <ramana dot radhakrishnan at arm dot com>
- Cc: Richard Henderson <rth at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, James Greenhalgh <James dot Greenhalgh at arm dot com>
- Date: Fri, 14 Nov 2014 09:14:34 +0000
- Subject: Re: [Patch AArch64] Fix PR 63724 - Improve immediate generation
- Authentication-results: sourceware.org; auth=none
- References: <20141107120230 dot GA14486 at e105545-lin> <545CCACD dot 9050204 at redhat dot com> <54638EE8 dot 4060402 at arm dot com>
On 12 November 2014 16:46, Ramana Radhakrishnan
<ramana.radhakrishnan@arm.com> wrote:
> v2 , based on Richard's suggestion as well as fixing a bug that I hit in
> some more testing at O1. aarch64_internal_mov_immediate should not generate
> a temporary for subtarget when not actually "generating" code.
>
> Tested again on aarch64-none-elf and with a bootstrap / reg test. Ok ?
>
>
> <DATE> Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
>
> PR target/63724
> * config/aarch64/aarch64.c (aarch64_expand_mov_immediate): Split out
> numerical immediate handling to...
> (aarch64_internal_mov_immediate): ...this. New.
> (aarch64_rtx_costs): Use aarch64_internal_mov_immediate.
> (aarch64_mov_operand_p): Relax predicate.
> * config/aarch64/aarch64.md (mov<mode>:GPI): Do not expand
> CONST_INTs.
> (*movsi_aarch64): Turn into define_insn_and_split and new
> alternative
> for 'n'.
> (*movdi_aarch64): Likewise.
OK.
We should be able to remove aarch64_build_constant now.
/Marcus