Re: Updated LRA rematerialization patch has been committed

[Vladimir Makarov <vmakarov at redhat dot com>]

On 2014-11-12 11:06 PM, H.J. Lu wrote:

> Unfortunately, it breaks bootstrap on Linux/ia32:
>
> https://gcc.gnu.org/ml/gcc-regression/2014-11/msg00288.html
>
> ../../../src-trunk/libgcc/config/libbid/bid_round.c: In function
> Ã__bid_round128_19_38Ã:
> ../../../src-trunk/libgcc/config/libbid/bid_round.c:391:1: internal
> compiler error: Segmentation fault
>   }
>   ^
> /export/gnu/import/git/gcc-test-ia32corei7/bld/./gcc/xgcc
> -B/export/gnu/import/git/gcc-test-ia32corei7/bld/./gcc/
> -B/usr/5.0.0/i686-linux/bin/ -B/usr/5.0.0/i686-linux/lib/ -isystem
> /usr/5.0.0/i686-linux/include -isystem
> /usr/5.0.0/i686-linux/sys-include    -g -O2 -O2  -g -O2 -DIN_GCC    -W
> -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wstrict-prototypes
> -Wmissing-prototypes -Wold-style-definition  -isystem ./include
> -fpic -mlong-double-80 -g -DIN_LIBGCC2 -fbuilding-libgcc
> -fno-stack-protector   -fpic -mlong-double-80 -I. -I. -I../.././gcc
> -I../../../src-trunk/libgcc -I../../../src-trunk/libgcc/.
> -I../../../src-trunk/libgcc/../gcc
> -I../../../src-trunk/libgcc/../include
> -I../../../src-trunk/libgcc/config/libbid -DENABLE_DECIMAL_BID_FORMAT
> -DHAVE_CC_TLS  -DUSE_TLS -o bid128.o -MT bid128.o -MD -MP -MF
> bid128.dep -c ../../../src-trunk/libgcc/config/libbid/bid128.c
> Please submit a full bug report,
> with preprocessed source if appropriate.
> See <http://gcc.gnu.org/bugs.html> for instructions.
> make[6]: *** [bid_round.o] Error 1
>
> when configured with
>
> --with-arch=corei7 --with-cpu=corei7 --prefix=/usr/5.0.0
> --enable-clocale=gnu --with-system-zlib --enable-shared
> --with-demangler-in-ld i686-linux --with-fpmath=sse
> --enable-languages=c,c++,fortran,java,lto,objc

Thanks, H.J.  I'll investigate it.  Meanwhile, I switched the pass off 
temporarily.

Index: ChangeLog
===================================================================
--- ChangeLog   (revision 217458)
+++ ChangeLog   (working copy)
@@ -1,3 +1,7 @@
+2014-11-13  Vladimir Makarov  <vmakarov@redhat.com>
+
+       * lra.c (lra): Switch off rematerialization pass.
+
 2014-11-12  Vladimir Makarov  <vmakarov@redhat.com>

        * common.opt (flra-remat): New.
Index: lra.c
===================================================================
--- lra.c       (revision 217458)
+++ lra.c       (working copy)
@@ -2349,7 +2349,7 @@
        }
       /* Now we know what pseudos should be spilled.  Try to
         rematerialize them first.  */
-      if (lra_remat ())
+      if (0 && lra_remat ())
        {
          /* We need full live info -- see the comment above.  */
          lra_create_live_ranges (lra_reg_spill_p);