This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/4] Add liboffloadmic
- From: Ilya Verbin <iverbin at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Andrey Turetskiy <andrey dot turetskiy at gmail dot com>
- Date: Wed, 12 Nov 2014 16:20:41 +0300
- Subject: Re: [PATCH 2/4] Add liboffloadmic
- Authentication-results: sourceware.org; auth=none
- References: <20141021171323 dot GA47586 at msticlxl57 dot ims dot intel dot com> <20141021172034 dot GC47586 at msticlxl57 dot ims dot intel dot com> <20141022085453 dot GK10376 at tucnak dot redhat dot com> <20141022192128 dot GB21398 at msticlxl57 dot ims dot intel dot com> <20141106182131 dot GP5026 at tucnak dot redhat dot com> <20141112104033 dot GT5026 at tucnak dot redhat dot com>
On 06 Nov 19:21, Jakub Jelinek wrote:
> I'm still seeing various unhandled malloc failures, e.g.:
> ...
> would crash if malloc returns NULL. Similarly for realloc:
Fixed in the branch:
https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=534b201fadf0af05ca509dc3f8e13ef26ee719a2
> Also, I see you heavily use malloc.h, not sure how portable that is,
> certainly e.g. gcc checks through configure for its presence. I suppose
> stdlib.h being more portable. Or, if you want liboffloadmic to be supported
> only on i?86-*-linux* / x86_64-*-linux* rather than all i?86/x86_64 targets,
> maybe you should say so in configure.tgt. If you leave it on for all
> i?86/x86_64 targets, be prepared to handle issues on Darwin, mingw/cygwin,
> BSDs etc.
So far we have tested only i686/x86_64 linux, but probably we will support other
systems in the future.
I restricted $target to x86_64-*-linux* and i?86-*-linux* in configure.tgt.
On 12 Nov 11:40, Jakub Jelinek wrote:
> So, the whole series is ok to check in now. Thanks.
Great, thank you!
We're going to check in all patches today after additional regtesting.
-- Ilya