This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Remove for_each_rtx

From: Jeff Law <law at redhat dot com>
To: gcc-patches at gcc dot gnu dot org, richard dot sandiford at arm dot com
Date: Tue, 11 Nov 2014 09:26:18 -0700
Subject: Re: Remove for_each_rtx
Authentication-results: sourceware.org; auth=none
References: <87vbmlivy5 dot fsf at e105548-lin dot cambridge dot arm dot com>

On 11/11/14 08:44, Richard Sandiford wrote:

There are no more callers to for_each_rtx or for_each_rtx_in_insn,
so this patch removes the functions.

Tested on x86_64-linux-gnu.  OK to install?

Thanks,
Richard


gcc/
	* rtl.h (rtx_function, for_each_rtx, for_each_rtx_in_insn): Delete.
	* rtlanal.c (non_rtx_starting_operands, for_each_rtx_1, for_each_rtx):
	(for_each_rtx_in_insn): Delete.
	(init_rtlanal): Remove initialization of non_rtx_starting_operands.
	* df-core.c: Remove reference to for_each_rtx in comment.

Yes. And in general, I think removing an unused, non-debug functionought to be considered obvious to install w/o review.

While there's some concern about breaking out-of-tree ports, I thinkgetting the dead code out of GCC proper trumps that concern. There's apath forward for out-of-tree ports and it's the natural cost of keepinga port out-of-tree.


jeff

References:
- Remove for_each_rtx
  - From: Richard Sandiford

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]