This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix libtool.m4 for Darwin >= 10.10
- From: Jakub Jelinek <jakub at redhat dot com>
- To: FX <fxcoudert at gmail dot com>
- Cc: Jack Howarth <howarth dot at dot gcc at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 11 Nov 2014 16:03:15 +0100
- Subject: Re: Fix libtool.m4 for Darwin >= 10.10
- Authentication-results: sourceware.org; auth=none
- References: <D7EC6C1D-8992-48B6-9697-E0BC6EFEEF02 at gmail dot com> <20141111090625 dot GA5026 at tucnak dot redhat dot com> <AE080D19-5EED-4ACF-9D96-98C36A61B1E0 at gmail dot com> <CAJMcOU_Rcj1y36SxsnWKokbXQUy8mqRoR+52Q-ht7ErZ1Jy5RQ at mail dot gmail dot com> <8C51AB2A-8E6C-40DF-A60E-07BDF9FA1016 at gmail dot com> <CAJMcOU9TMPTsPPXJjz=oPGtb47tFFHFwxSRx+SGur7jTjjr3mQ at mail dot gmail dot com> <CC96F45C-59C9-48B4-9FE5-FC7ED0E53320 at gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Nov 11, 2014 at 03:59:03PM +0100, FX wrote:
>
> > Since you are simply patching all the configure files, the question
> > seems academic unless you switch to properly regenerating all of the
> > configure files using a fixed libtool.m4.
>
> I am actually proposing to fix libtool.m4 and regenerate the configure scripts (which gives the same result as patching, as expected).
>
>
> > However these are maintained, the libjava configure files still need
> > to be patched to prevent their associated shared libraries from being
> > inappropriately linked with -flat_namespace on darwin14 and later.
>
> Yes, but I donât know whether libjava and classpath should be patched in
> GCC, or whether I should report them to be patched somewhere else (like
> libgo and zlib, for example). Itâs important to do it properly, otherwise
> codebases diverge and maintance becomes difficult.
libjava is maintained in GCC, libjava/classpath, while imported
occassionally from upstream, would upon merge result in regenerating the
generated files and thus should be patched too. For the latter,
you should put it into libjava/classpath/ChangeLog.gcj.
Jakub