This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

From: Bernd Schmidt <bernds at codesourcery dot com>
To: Eric Botcazou <ebotcazou at adacore dot com>, Jakub Jelinek <jakub at redhat dot com>
Cc: <gcc at gcc dot gnu dot org>, David Malcolm <dmalcolm at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>
Date: Tue, 11 Nov 2014 12:52:03 +0100
Subject: Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign
Authentication-results: sourceware.org; auth=none
References: <1415373690-26193-1-git-send-email-dmalcolm at redhat dot com> <1415658470 dot 2209 dot 20 dot camel at surprise> <20141111072614 dot GW5026 at tucnak dot redhat dot com> <12114358 dot axzaQBLi7W at polaris>

On 11/11/2014 09:30 AM, Eric Botcazou wrote:

I just don't like all the as_a/is_a stuff enforced everywhere,
it means more typing, more temporaries, more indentation.
So, as I view it, instead of the checks being done cheaply (yes, I think
the gimple checking as we have right now is very cheap) under the
hood by the accessors (gimple_assign_{lhs,rhs1} etc.), those changes
put the burden on the developers, who has to check that manually through
the as_a/is_a stuff everywhere, more typing and uglier syntax.
I just don't see that as a step forward, instead a huge step backwards.
But perhaps I'm alone with this.


IMO that's the sort of things some of us were afraid of when the C++ switch
was being discussed and IIRC we were told this would not happen...


I'm with both of you on this.


Bernd

References:
- [gimple-classes, committed 0/6] Use gassign in 6 tree-ssa-* files
  - From: David Malcolm
- Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign
  - From: David Malcolm
- Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign
  - From: Jakub Jelinek
- Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]