Re: RFC: Update ISL under gcc/infrastructure/ ? // Remove CLooG?

[Jack Howarth <howarth dot at dot gcc at gmail dot com>]

    On x86_64-apple-darwin14, the attached patch allows gcc trunk to
build against isl 0.14. I assume if we want to retain the...

#if defined(__cplusplus)
extern "C" {
#endif

#if defined(__cplusplus)
}
#endif

wrappers around the include of  isl/val_gmp.h, to continue to support
isl 0.12.2, isl.m4 will need to test for isl <= 0.12.2 and set a
define in autohost.h that can be added to the conditional on
_cplusplus. The same define would have to be used in a conditional for
selecting code changes required for using...

if (isl_band_member_is_zero_distance (Band, i))

in gcc/graphite-optimize-isl.c for isl <= 0.12.2 rather than...

if (isl_band_member_is_coincident (Band, i))

and the other associated changes for isl >  0.12.2.
            Jack
ps The changes in gcc/graphite-optimize-isl.c are modelled on those in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191650#c6.

pps The test suite results for "make -k check
RUNTESTFLAGS="graphite.exp --target_board=unix'{-m32,-m64}'"" are...

LAST_UPDATED: Obtained from SVN: trunk revision 217269

Native configuration is x86_64-apple-darwin13.4.0

=== g++ tests ===

Running target unix/-m32

=== g++ Summary for unix/-m32 ===

# of expected passes 27

Running target unix/-m64

=== g++ Summary for unix/-m64 ===

# of expected passes 27

=== g++ Summary ===

# of expected passes 54
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/testsuite/g++/../../xg++
 version 5.0.0 20141109 (experimental) (GCC)

=== gcc tests ===

Running target unix/-m32
FAIL: gcc.dg/graphite/vect-pr43423.c scan-tree-dump-times vect
"vectorized 2 loops" 1
UNRESOLVED: gcc.dg/graphite/isl-codegen-loop-dumping.c
scan-tree-dump-times graphite "ISL AST generated by ISL: \\nfor
\\\\(int c1 = 0; c1 < n - 1; c1 \\\\+= 1\\\\)\\n  for \\\\(int c3 = 0;
c3 < n; c3 \\\\+= 1\\\\)\\n    S_4\\\\(c1, c3\\\\);" 1

=== gcc Summary for unix/-m32 ===

# of expected passes 299
# of unexpected failures 1
# of expected failures 4
# of unresolved testcases 1
# of unsupported tests 5

Running target unix/-m64
FAIL: gcc.dg/graphite/vect-pr43423.c scan-tree-dump-times vect
"vectorized 2 loops" 1
UNRESOLVED: gcc.dg/graphite/isl-codegen-loop-dumping.c
scan-tree-dump-times graphite "ISL AST generated by ISL: \\nfor
\\\\(int c1 = 0; c1 < n - 1; c1 \\\\+= 1\\\\)\\n  for \\\\(int c3 = 0;
c3 < n; c3 \\\\+= 1\\\\)\\n    S_4\\\\(c1, c3\\\\);" 1

=== gcc Summary for unix/-m64 ===

# of expected passes 299
# of unexpected failures 1
# of expected failures 4
# of unresolved testcases 1
# of unsupported tests 5

=== gcc Summary ===

# of expected passes 598
# of unexpected failures 2
# of expected failures 8
# of unresolved testcases 2
# of unsupported tests 10
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/xgcc  version
5.0.0 20141109 (experimental) (GCC)

=== gfortran tests ===

Running target unix/-m32

=== gfortran Summary for unix/-m32 ===

# of expected passes 112
# of expected failures 14

Running target unix/-m64

=== gfortran Summary for unix/-m64 ===

# of expected passes 110
# of expected failures 14
# of unsupported tests 2

=== gfortran Summary ===

# of expected passes 222
# of expected failures 28
# of unsupported tests 2
/sw/src/fink.build/gcc50-5.0.0-1000/darwin_objdir/gcc/testsuite/gfortran/../../gfortran
 version 5.0.0 20141109 (experimental) (GCC)

=== libgomp tests ===

Running target unix/-m32

=== libgomp Summary for unix/-m32 ===

# of expected passes 49

Running target unix/-m64

=== libgomp Summary for unix/-m64 ===

# of expected passes 49

=== libgomp Summary ===

# of expected passes 98

Compiler version: 5.0.0 20141109 (experimental) (GCC)
Platform: x86_64-apple-darwin13.4.0
configure flags: --prefix=/sw --prefix=/sw/lib/gcc5.0
--mandir=/sw/share/man --infodir=/sw/lib/gcc5.0/info
--enable-languages=c,c++,fortran,lto,objc,obj-c++,java --with-gmp=/sw
--with-libiconv-prefix=/sw --with-isl=/sw --without-cloog
--with-mpc=/sw --with-system-zlib --x-includes=/usr/X11R6/include
--x-libraries=/usr/X11R6/lib --program-suffix=-fsf-5.0


On Mon, Nov 10, 2014 at 2:27 PM, Jack Howarth <howarth.at.gcc@gmail.com> wrote:
>      Is the current isl 0.12.2 in infrastructure entirely sufficient
> to replace cloog-isl. or should the ABI compatibility changes be made
> to graphite to allow gcc 5.0 to be transitioned to the isl 0.14
> release? Especially if any graphite changes might be made before the
> gcc 5.0 release that could leverage new functionalities in isl 0.14.
>             Jack
>
>
> On Sun, Nov 9, 2014 at 12:16 PM, Roman Gareev <gareevroman@gmail.com> wrote:
>> Hi Tobias,
>>
>> I've attached a patch which removes using of CLooG library from
>> Graphite. Is it fine for trunk?
>>
>>
>> --
>>                                     Cheers, Roman Gareev.

Attachment: isl_0.14.diff
Description: Text document