This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 12/27] New file: gcc/jit/jit-recording.h
- From: Jeff Law <law at redhat dot com>
- To: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org, jit at gcc dot gnu dot org
- Date: Mon, 03 Nov 2014 14:27:36 -0700
- Subject: Re: [PATCH 12/27] New file: gcc/jit/jit-recording.h
- Authentication-results: sourceware.org; auth=none
- References: <1414774977-25605-1-git-send-email-dmalcolm at redhat dot com> <1414774977-25605-13-git-send-email-dmalcolm at redhat dot com>
On 10/31/14 11:02, David Malcolm wrote:
This file declares the gcc::jit::recording internal API, so that
libgccjit.c can record the calls that are made to the public API, for
later playback by the dummy frontend.
gcc/jit/
* jit-recording.h: New.
---
gcc/jit/jit-recording.h | 1593 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 1593 insertions(+)
create mode 100644 gcc/jit/jit-recording.h
diff --git a/gcc/jit/jit-recording.h b/gcc/jit/jit-recording.h
new file mode 100644
index 0000000..bb1a2ee
--- /dev/null
+++ b/gcc/jit/jit-recording.h
[ ... ]
+
+private:
+ void validate ();
So give the complexities in interfacing with the guts of GCC, would it
make sense to expose the validate method?
+/* or just use std::string? */
+class string : public memento
Is there some reason not to use std::string? I really like using
standard components rather than rolling our own.
OK for the trunk.
jeff