This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes
- From: Ramana Radhakrishnan <ramana dot gcc at googlemail dot com>
- To: Michael Collison <michael dot collison at linaro dot org>
- Cc: Tejas Belagod <tejas dot belagod at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 31 Oct 2014 17:41:33 +0000
- Subject: Re: [ARM] Fix CLZ_DEFINED_VALUE_AT_ZERO for vector modes
- Authentication-results: sourceware.org; auth=none
- References: <543633BD dot 9030004 at linaro dot org> <54363F8A dot 8020501 at arm dot com> <54482653 dot 5060805 at linaro dot org>
- Reply-to: ramrad01 at arm dot com
On Wed, Oct 22, 2014 at 10:49 PM, Michael Collison
<michael.collison@linaro.org> wrote:
>
> Patch that removes extraneous comment attached.
>
> The CLZ_DEFINED_VALUE_AT_ZERO macro is hard coded to return 32. For the
> vector intrinsic vclz this is incorrect and should return the value
vclz_{s,u}8 ...
> eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue.
The patch is ok . Sorry about the delay in reviewing this.
Ramana
>
> Tested on arm-linux-gnueabihf, arm-linux-gnueabi.
>
> 2014-10-08 Michael Collison <michael.collison@linaro.com>
>
> * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update
> to support vector modes
> (CTZ_DEFINED_VALUE_AT_ZERO): Ditto
>
> On 10/09/2014 12:55 AM, Tejas Belagod wrote:
>>
>> On 09/10/14 08:05, Michael Collison wrote:
>>>
>>>
>>> The CLZ_DEFINED_VALUE_AT_ZERO macro is harded to return 32. For the
>>> vector intrinsic vclz this is incorrect and should return the value
>>> eight. The CTZ_DEFINED_VALUE_AT_ZERO has the same issue.
>>>
>>> Tested on arm-linux-gnueabihf, arm-linux-gnueabi.
>>>
>>> 2014-10-08 Michael Collison <michael.collison@linaro.com>
>>>
>>> * config/arm/arm.h (CLZ_DEFINED_VALUE_AT_ZERO) : Update
>>> to support vector modes
>>> (CTZ_DEFINED_VALUE_AT_ZERO): Ditto
>>>
>>
>> Update comment?
>>
>> /* The arm5 clz instruction returns 32. */
>>
>>
>> Thanks,
>> Tejas.
>>
>
> --
> Michael Collison
> Linaro Toolchain Working Group
> michael.collison@linaro.org
>