This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gofrontend-dev] Re: [PATCH 7/9] Gccgo port to s390[x] -- part I


On Fri, Oct 31, 2014 at 2:11 AM, Dominik Vogt <vogt@linux.vnet.ibm.com> wrote:
> On Thu, Oct 30, 2014 at 07:51:45AM -0700, Ian Taylor wrote:
>> On Thu, Oct 30, 2014 at 12:25 AM, Dominik Vogt <vogt@linux.vnet.ibm.com> wrote:
>> > See attached patch.
>>
>> I don't mind skipping the test on other platforms, but xfail is not
>> correct.  When an xfail test passes, we get an XPASS error from the
>> testsuite.  We need dg-skip-if.  I committed this patch.
>
> That is exactly the reason why I chose dg-xfail-if:  To identify
> the targets where the test works out of the box, because I think
> there won't be many of them.

That would be fine if coupled with an immediate plan to test on all
systems.  What we don't want is an XPASS on some random system six
months from now that forces some poor GCC developer who knows nothing
at all about this code to figure out what is going on.


> But anyway, we can leave it as it is for the moment and eventually
> I'll get around cleaning that up.

OK.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]