This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work)
- From: Ian Taylor <iant at golang dot org>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: Joern Rennecke <joern dot rennecke at embecosm dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 30 Oct 2014 17:10:38 -0700
- Subject: Re: [PATCH] config-list.mk: Build Go only for supported targets (was: Patch RFA: Top-level configure patch: disable go on systems where it doesn't work)
- Authentication-results: sourceware.org; auth=none
- References: <CAOyqgcUFmBppk_jDpeO+raujT5P7eNtGrNVH3HbhnSWGRWtbUQ at mail dot gmail dot com> <20141027150658 dot GZ28215 at lug-owl dot de> <CAOyqgcWO+C86WsGphJcwNQkTZSihFucJS5WrvvFN611mhgMb_g at mail dot gmail dot com> <20141027160244 dot GA28215 at lug-owl dot de> <CAOyqgcWBYbRGT4wjTvhv-8x273_u1-QOaqwYV0XJSxyPpkXjgQ at mail dot gmail dot com> <20141030131947 dot GF28215 at lug-owl dot de> <CAOyqgcV_ZANwRhm5deps5OfJhDB=GyM01bYs1D8QB9XCS+wwGA at mail dot gmail dot com> <20141030191457 dot GG28215 at lug-owl dot de>
On Thu, Oct 30, 2014 at 12:14 PM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
> On Thu, 2014-10-30 08:08:51 -0700, Ian Taylor <iant@golang.org> wrote:
>> On Thu, Oct 30, 2014 at 6:19 AM, Jan-Benedict Glaw <jbglaw@lug-owl.de> wrote:
>> >
>> > This updates contrib/config-list.mk to build Go for all but
>> > known-non-working targets. A comment to configure{.ac,} is also added.
>>
>> > diff --git a/contrib/config-list.mk b/contrib/config-list.mk
>> > index 94884d9..16900e1 100644
>> > --- a/contrib/config-list.mk
>> > +++ b/contrib/config-list.mk
>> > @@ -95,11 +95,24 @@ make-log-dir: ../gcc/MAINTAINERS
>> >
>> > $(LIST): make-log-dir
>> > -mkdir $@
>> > - (cd $@ && \
>> > - ../../gcc/configure \
>> > - --target=$(subst SCRIPTS,`pwd`/../scripts/,$(subst OPT,$(empty) -,$@)) \
>> > - --enable-werror-always ${host_options} --enable-languages=all,ada,go) \
>> > - > log/$@-config.out 2>&1
>> > + ( \
>> > + cd $@ && \
>> > + echo $@ && \
>> > + TGT=`echo $@ | sed -e 's/^\(.*\)OPT.*$$/\1/'` && \
>> > + TGT=`../../gcc/config.sub $$TGT` && \
>>
>> This isn't necessary. The OPT bits will be matched by the * at the
>> end of the cases anyhow. You can just write
>> case $@ in
>>
>> This is OK with that change.
>
> Not exactly: My intention was to keep the triplet matches as they show
> up in configure.ac . However, the target list in config-list.mk uses
> (almost exclusively) shorthands for all the targets, so these need to
> be expand (--> config.sub); that however won't really fly with the
> OPTs in there.
Oh, right, sorry.
The original patch is OK.
Thanks.
Ian