This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, MIPS] Add Octeon3 support
- From: "Moore, Catherine" <Catherine_Moore at mentor dot com>
- To: "Hurugalawadi, Naveen" <Naveen dot Hurugalawadi at caviumnetworks dot com>, "Matthew Fortune" <Matthew dot Fortune at imgtec dot com>, "Myers, Joseph" <joseph_myers at mentor dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "Pinski, Andrew" <Andrew dot Pinski at caviumnetworks dot com>
- Date: Thu, 30 Oct 2014 19:46:48 +0000
- Subject: RE: [Patch, MIPS] Add Octeon3 support
- Authentication-results: sourceware.org; auth=none
- References: <1412659579490 dot 88923 at caviumnetworks dot com>,<Pine dot LNX dot 4 dot 64 dot 1410071716170 dot 28196 at digraph dot polyomino dot org dot uk> <1412750831616 dot 26037 at caviumnetworks dot com>,<6D39441BF12EF246A7ABCE6654B0235320F2DEBD at LEMAIL01 dot le dot imgtec dot org> <1414652377082 dot 43172 at caviumnetworks dot com>
> -----Original Message-----
> From: gcc-patches-owner@gcc.gnu.org [mailto:gcc-patches-
> Sent: Thursday, October 30, 2014 2:59 AM
> Subject: Re: [Patch, MIPS] Add Octeon3 support
>
> Hi,
>
> Thanks for the review and your comments.
>
> >> Is it intentional that you have not updated driver-native.c to detect
> >> an Octeon 3 CPU?
>
> We have not yet looked into that part yet and will be looking at it later.
>
> >> Could you confirm what testing the patch has had?
>
> Run the regression in build folder of gcc using make-check.
> The compilation results are good.
> Also we have been using the octeon3 patches in cavium toolchain from
> sometime without any issues.
>
Hi Naveen,
This patch looks good except that is missing testcases. Would you please add some testcases and resubmit your patch?
Thanks,
Catherine