This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH][ARM] Fix/revert fallout from machine_mode change


On Wed, Oct 29, 2014 at 5:50 PM, Joseph S. Myers
<joseph@codesourcery.com> wrote:
> On Wed, 29 Oct 2014, Kyrill Tkachov wrote:
>
>> Hi all,
>>
>> This fixes an arm build failure due to removing the 'enum' keyword from
>> machine_mode.
>> Since libgcc2 is compiled with C rather than C++ we need it there for the
>> definition of CUMULATIVE_ARGS.
>
> But why is CUMULATIVE_ARGS needed for libgcc?
>

You are right it shouldn't be required. Thanks for pointing this out.


> It's desirable to eliminate use of host-side headers in target-side code
> (I'd welcome more people picking up pieces of the target macros work
> described at <https://gcc.gnu.org/wiki/Top-Level_Libgcc_Migration>, though
> you shouldn't rely on the distinctions there about where I suggest a
> particular macro should move; it's quite likely there are better choices
> in various cases).  Thus, if something in host-side headers is causing
> problems in target-side code, I'd think the obvious fix is to condition
> out the relevant code when building for the target, rather than fixing it
> to work (although meaningless) for the target.


Sure,  fixed thusly for ARM after verifying a build succeeds for
arm-none-linux-gnueabihf cross (after verifying that reverting
Kyrill's patch breaks the build) . Will have to deal with AArch64 in
the morning unless someone beats me to it.

Ramana

2014-10-29  Ramana Radhakrishnan  <ramana.radhakrishnan@arm.com>

        * config/arm/arm.h (MACHMODE): Treat machine_mode as a
        scalar typedef.
        (CUMULATIVE_ARGS): Guard against target includes.
        (machine_function): Likewise.




>
> --
> Joseph S. Myers
> joseph@codesourcery.com

Attachment: p1.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]