This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/X, i386, PR54232] Enable EBX for x86 in 32bits PIC code


The test passes now. So let's remove xfail.

2014-10-29  Evgeny Stupachenko  <evstupac@gmail.com>

gcc/testsuite
        * gcc.target/i386/pr23098.c: Remove xfail.

diff --git a/gcc/testsuite/gcc.target/i386/pr23098.c
b/gcc/testsuite/gcc.target/i386/pr23098.c
index 7f118dc..7f118bb 100644
--- a/gcc/testsuite/gcc.target/i386/pr23098.c
+++ b/gcc/testsuite/gcc.target/i386/pr23098.c
@@ -1,7 +1,7 @@
 /* PR rtl-optimization/23098 */
 /* { dg-do compile } */
 /* { dg-options "-O2 -fPIC" } */
-/* { dg-final { scan-assembler-not "\.LC\[0-9\]" { xfail *-*-* } } } */
+/* { dg-final { scan-assembler-not "\.LC\[0-9\]" } } */
 /* { dg-require-effective-target ia32 } */
 /* { dg-require-effective-target fpic } */

On Thu, Oct 23, 2014 at 4:19 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:
> Evgeny Stupachenko <evstupac@gmail.com> writes:
>
>> Reattached.
>>
>> On Mon, Oct 13, 2014 at 8:22 PM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>> On Mon, Oct 13, 2014 at 4:53 PM, Evgeny Stupachenko <evstupac@gmail.com>
>>> wrote:
>>>
>>>> ChangeLog for testsuite:
>>>>
>>>> 2014-10-13  Evgeny Stupachenko  <evstupac@gmail.com>
>>>>
>>>>         PR target/8340
>>>>         PR middle-end/47602
>>>>         PR rtl-optimization/55458
>>>>         * gcc.target/i386/pic-1.c: Remove dg-error as test should pass now.
>>>>         * gcc.target/i386/pr55458.c: Likewise.
>>>>         * gcc.target/i386/pr47602.c: New.
>>>>         * gcc.target/i386/pr23098.c: Move to XFAIL.
>
> The unconditional XFAIL is wrong: the test now XPASSes on
> i386-pc-solaris2.11 and x86_64-unknown-linux-gnu, i686-unknown-linux-gnu
> for 32-bit.  Please fix.
>
>         Rainer
>
> --
> -----------------------------------------------------------------------------
> Rainer Orth, Center for Biotechnology, Bielefeld University


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]