This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch 1/6] Hookize MOVE_BY_PIECES_P, remove most uses of MOVE_RATIO
- From: Matthew Fortune <Matthew dot Fortune at imgtec dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Cc: "richard dot guenther at gmail dot com" <richard dot guenther at gmail dot com>, "stevenb dot gcc at gmail dot com" <stevenb dot gcc at gmail dot com>
- Date: Wed, 29 Oct 2014 11:42:06 +0000
- Subject: RE: [Patch 1/6] Hookize MOVE_BY_PIECES_P, remove most uses of MOVE_RATIO
- Authentication-results: sourceware.org; auth=none
- References: <1411657056-24865-2-git-send-email-james dot greenhalgh at arm dot com> <1414579486-22492-1-git-send-email-james dot greenhalgh at arm dot com> <1414579486-22492-2-git-send-email-james dot greenhalgh at arm dot com>
Hi James,
I think you have a bug in the following hunk where you pass
STORE_MAX_PIECES in place of the optimise for speed flag. I guess you
would need an extra argument to pass a different *_MAX_PIECES value
in.
thanks,
Matthew
>@@ -192,8 +184,7 @@ static void write_complex_part (rtx, rtx, bool);
> called to "memcpy" storage when the source is a constant string. */
> #ifndef STORE_BY_PIECES_P
> #define STORE_BY_PIECES_P(SIZE, ALIGN) \
>- (move_by_pieces_ninsns (SIZE, ALIGN, STORE_MAX_PIECES + 1) \
>- < (unsigned int) MOVE_RATIO (optimize_insn_for_speed_p ()))
>+ (targetm.move_by_pieces_profitable_p (SIZE, ALIGN, STORE_MAX_PIECES))
> #endif
>
>
> /* This is run to set up which modes can be use