This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [x86] RFA: Use new rtl iterators in ix86_loop_unroll_adjust


On Sat, Oct 25, 2014 at 11:11 AM, Richard Sandiford
<rdsandiford@googlemail.com> wrote:
> This is part of a series to remove uses of for_each_rtx from the ports.
>
> It looks like this code should be iterating over the pattern rather than
> the full insn, or do MEMs in notes really count?  If we iterate over the
> pattern then there should be no need for the test for null.
>
> Tested by making sure there were no code changes for gcc.dg, gcc.c-torture
> and g++.dg for x86_64-linux-gnu, and also by a boostrap.  OK to install?
>
> Thanks,
> Richard
>
>
> gcc/
>         * config/i386/i386.c (ix86_loop_memcount): Delete.
>         (ix86_loop_unroll_adjust): Use FOR_EACH_SUBRTX.


Please also move the following comment to new place instead of removing it:

-/* This function gives out the number of memory references.
-   This value determines the unrolling factor for
-   bdver3 and bdver4 architectures. */

OK with this change.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]