This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Verbin <iverbin at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Andrey Turetskiy <andrey dot turetskiy at gmail dot com>
- Date: Fri, 24 Oct 2014 18:07:01 +0200
- Subject: Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp
- Authentication-results: sourceware.org; auth=none
- References: <20141006155317 dot GA34830 at msticlxl57 dot ims dot intel dot com> <20141008110812 dot GX1986 at tucnak dot redhat dot com> <20141024160342 dot GA11273 at msticlxl57 dot ims dot intel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Oct 24, 2014 at 08:03:42PM +0400, Ilya Verbin wrote:
> A small addition, refcount and copy_from were uninitialized for globals.
>
>
> diff --git a/libgomp/target.c b/libgomp/target.c
> index 4ace170..5b4873b 100644
> --- a/libgomp/target.c
> +++ b/libgomp/target.c
> @@ -647,6 +647,8 @@ gomp_init_device (struct gomp_device_descr *devicep)
> k->host_start = table[i].host_start;
> k->host_end = table[i].host_end;
> k->tgt_offset = 0;
> + k->refcount = 1;
> + k->copy_from = false;
> k->tgt = tgt;
> node->left = NULL;
> node->right = NULL;
Is that what Kirill reported today on IRC? LGTM.
Jakub