This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH i386 AVX512] [87/n] Add rest of the tests.


On Wed, Oct 22, 2014 at 2:59 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> On 22 Oct 16:48, Kirill Yukhin wrote:
>> Hello,
>> This patch adds tests for new intrinsics.
>>
>> Bootstrapped.
>> AVX-512* tests on top of patch-set all pass
>> under simulator.
>>
>> Is it ok for trunk?
>>
>> gcc/
>>       * testsuite/gcc.target/i386/avx512bw-check.h: New.
> Please, disregard "testsuite/gcc.target" in overall ChangeLog entry.

One general observation: You will need \[0-9\]+ after %xmm,%ymm and
%zmm and \[0-7\] or \[1-7\] after %k in the asm scan strings. Please
note the "+" in the first case.

However, I see that this issue is already present in the testsuite,
but IMO should be fixed for all cases in the followup patch.

The cases in the pathc follow the same approach as existing testcases, so:

OK.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]