This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap

On 10/22/14 15:40, Jakub Jelinek wrote:



diff --git a/gcc/dce.c b/gcc/dce.c
index 5b7d36e..a52a59c 100644
--- a/gcc/dce.c
+++ b/gcc/dce.c
@@ -127,6 +127,10 @@ deletable_insn_p (rtx_insn *insn, bool fast,
bitmap arg_stores)
      if (HARD_REGISTER_NUM_P (DF_REF_REGNO (def))
         && global_regs[DF_REF_REGNO (def)])
        return false;
+    /* Initialization of pseudo PIC register should never be removed.  */
+    else if (DF_REF_REG (def) == pic_offset_table_rtx
+            && REGNO (pic_offset_table_rtx) >= FIRST_PSEUDO_REGISTER)
+      return false;

Similarly.


But here, after reload completes, there shouldn't be pseudos in the IL, so
the condition should not trigger anymore.

Agreed.
So just the first one needs to check for !reload_completed. With that change, and a bootstrap/regression run the patch is OK for the trunk. 

Jeff
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]