This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, testsuite] clear wrap_compile_flags before setting it


On 10/17/14 15:05, Christophe Lyon wrote:
Hi,

In testsuite/lib/wrapper.exp's ${tool}_maybe_build_wrapper, we call
set_currtarget_info wrap_compile_flags
to override wrap_compile_flags with additional flags when compiling testglue.c.

However, dejagnu's set_currtarget_info {entry value} will write into
value only if it's not already defined.

This caused me problems since I had defined wrap_compile_flags much
earlier in my main .exp file: -w was not added, causing compilation of
testglue.c to fail under RHEL5.

The attach patch unsets wrap_compile_flags before calling set_currtarget_info.

OK for trunk?

Thanks,
Christophe

2014-10-17  Christophe Lyon  <christophe.lyon@linaro.org>

        * lib/wrapper.exp ({tool}_maybe_build_wrapper): Clear
        wrap_compile_flags before setting it.
OK.

Sigh. One day someone will rewrite all this nonsense in something other than expect/tcl. Until then we slog along ;(

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]