This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Evgeny Stupachenko <evstupac at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Jeff Law <law at redhat dot com>, Uros Bizjak <ubizjak at gmail dot com>, iains at gcc dot gnu dot org
- Date: Wed, 22 Oct 2014 18:01:19 +0200
- Subject: Re: [PARCH 2/2, x86, PR63534] Fix darwin bootstrap
- Authentication-results: sourceware.org; auth=none
- References: <CAOvf_xxtWrrAm_z3s3-xGMqkPPA7SppL-woFG-4docMrmZ1xGw at mail dot gmail dot com> <CAOvf_xym6ajUDA2caCCtKr1=vVzOYZwaiV-0UO=Xyxhti2bDYg at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Oct 22, 2014 at 07:55:57PM +0400, Evgeny Stupachenko wrote:
> There is a test for Linux x86 that also fails without the changes in the patch:
>
> ChangeLog:
>
> 2014-10-22 Evgeny Stupachenko <evstupac@gmail.com>
>
> PR rtl-optimization/63618
> * gcc.target/i386/pr63618.c: New.
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr63618.c
> b/gcc/testsuite/gcc.target/i386/pr63618.c
> new file mode 100644
> index 0000000..cf10a2b
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/i386/pr63618.c
> @@ -0,0 +1,34 @@
> +/* PR rtl-optimization/63618 */
> +/* { dg-do run } */
> +/* { dg-require-effective-target sse4 } */
> +/* { dg-require-effective-target ia32 } */
> +/* { dg-options "-O2 -msse4.2 -mtune=corei7 -fno-inline -fPIC" } */
What is ia32 specific on the test?
As for -msse4.2 and sse4 effective target, I'd say
better would be to stick that to
/* { dg-additional-options "-msse4.2" { target sse4 } } */
Similarly, you want -fPIC only if { target fpic }, thus I'd say you want to
start the test with:
/* { dg-do run } */
/* { dg-options "-O2 -mtune=corei7 -fno-inline" } */
/* { dg-additional-options "-msse4.2" { target sse4 } } */
/* { dg-additional-options "-fpic" { target fpic } } */
Jakub