This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH i386 AVX512] [81/n] Add new built-ins.


On Tue, Oct 21, 2014 at 06:08:15PM +0400, Kirill Yukhin wrote:
> --- a/gcc/tree.h
> +++ b/gcc/tree.h
> @@ -2334,6 +2334,10 @@ extern void decl_value_expr_insert (tree, tree);
>  #define DECL_COMDAT(NODE) \
>    (DECL_WITH_VIS_CHECK (NODE)->decl_with_vis.comdat_flag)
>  
> + /* In a FUNCTION_DECL indicates that a static chain is needed.  */
> +#define DECL_STATIC_CHAIN(NODE) \
> +  (DECL_WITH_VIS_CHECK (NODE)->decl_with_vis.regdecl_flag)
> +

I would say that you should still keep it together with the FUNCTION_DECL
macros and use FUNCTION_DECL_CHECK there, to make it clear we don't want
the macro to be used on VAR_DECLs etc.
So just s/function_decl/decl_with_vis/ in the definition IMHO.

Also, with so many added builtins, how does it affect
int i;
compilation time at -O0?  If it is significant, maybe it is highest time to
make the md builtin decl building more lazy.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]