This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [jit] Error-handling within gcc::jit::dump


On Mon, 20 Oct 2014, David Malcolm wrote:

> On Fri, 2014-10-17 at 21:52 +0000, Joseph S. Myers wrote:
> [...snip static linkage discussion...]
> 
> > The dump file handling appears to have no I/O error checking (no checking 
> > for error on fopen, nothing obvious to prevent fwrite to a NULL m_file if 
> > fopen did have an error, no checking for error on fclose (or fwrite)).
> 
> Thanks.
> 
> Does the following look OK?  (I've committed it to branch
> dmalcolm/jit)

Seems fine with me.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]