This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Google/gcc-4_9][PATCH][target/x86_64] PR 63538
- From: Sriraman Tallam <tmsriram at google dot com>
- To: Andrew Pinski <pinskia at gmail dot com>
- Cc: Xinliang David Li <davidxl at google dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Jan Hubicka <hubicka at ucw dot cz>, Cary Coutant <ccoutant at google dot com>, Paul Pluzhnikov <ppluzhnikov at google dot com>
- Date: Mon, 20 Oct 2014 11:59:40 -0700
- Subject: Re: [Google/gcc-4_9][PATCH][target/x86_64] PR 63538
- Authentication-results: sourceware.org; auth=none
- References: <CAAs8HmzszJ+Pzm_pd0QjHNhbYsDhSrMGyq4zeC73pTD_Ws2_Yg at mail dot gmail dot com> <CAAkRFZJH6UiUOLE+ca-5oRXWt0_Bdqv1m8uxRK=XbgiezMnVUg at mail dot gmail dot com> <CAAs8Hmx9c+Kzz7mgw7OYX18Soex2oXJ_prN+3HQEuXf6p9aJ6g at mail dot gmail dot com> <CA+=Sn1kTOKeij_s7d+HE0a8MGDVDRrn2tWcPj6M-8Od4bmx8Vw at mail dot gmail dot com>
On Mon, Oct 20, 2014 at 10:51 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Mon, Oct 20, 2014 at 10:46 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>> On Mon, Oct 20, 2014 at 10:42 AM, Xinliang David Li <davidxl@google.com> wrote:
>>> Why removing the tree_code check?
>>
>> The actual problem happens because STRING_CSTs (end up in .lrodata)
>> are not set a far address as they dont match the VAR_DECL check here.
>> Futher, "ix86_in_large_data_p" call has the TREE_CODE check to do the
>> right thing so this seems unnecessary & buggy here.
>
> I think he is asking because TREE_STATIC (decl) || DECL_EXTERNAL
> (decl) might be an issue for STRING_CSTs.
TREE_STATIC is true for STRING_CSTs and DECL_EXTERNAL false, that looks ok.
Thanks
Sri
>
> Thanks,
> Andrew
>
>
>>
>> Thanks
>> Sri
>>
>>>
>>> David
>>>
>>> On Mon, Oct 20, 2014 at 10:35 AM, Sriraman Tallam <tmsriram@google.com> wrote:
>>>> Hi,
>>>>
>>>> This patch is under review for trunk GCC :
>>>> https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01638.html.
>>>>
>>>> In the mean time, is this ok for google/gcc-4_9 branch? Without
>>>> this, -mcmodel=medium is unusable if .lrodata goes beyond the 2G
>>>> boundary.
>>>>
>>>> Thanks
>>>> Sri