This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATH, libgfortran] PR 63589 Fix find_addr2line


On Sat, Oct 18, 2014 at 05:38:16PM +0300, Janne Blomqvist wrote:
> 
> Benoit Lodej reported on the fortran list a bug in find_addr2line,
> namely that if the PATH string does not end in ":", the last PATH
> element is not tested. Rather than fixing the current implementation,
> I rewrote it in a simpler fashion by using the strtok_r function.
> 
> Tested that it fixes the original bug, and with strace & valgrind that
> everything seems Ok (no regtest since we don't have anything in the
> testsuite which tests the backtrace functionality, AFAIK). Ok for
> trunk/4.9/4.8?
> 
> 2014-10-18  Janne Blomqvist  <jb@gcc.gnu.org>
> 
>     PR libfortran/63589
>     * configure.ac: Check for strtok_r.
>     * runtime/main.c (gfstrtok_r): Fallback implementation of
>     strtok_r.
>     (find_addr2line): Use strtok_r to split PATH.
>     * config.h.in: Regenerated.
>     * configure: Regenerated.
> 

OK.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]