This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 06/10] Heart of the JIT implementation (was: Re: [PATCH 0/5] Merger of jit branch (v2))
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: David Malcolm <dmalcolm at redhat dot com>
- Cc: <jit at gcc dot gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Oct 2014 21:52:24 +0000
- Subject: Re: [PATCH 06/10] Heart of the JIT implementation (was: Re: [PATCH 0/5] Merger of jit branch (v2))
- Authentication-results: sourceware.org; auth=none
- References: <1413222308-25753-1-git-send-email-dmalcolm at redhat dot com> <1413299342 dot 9513 dot 50 dot camel at surprise> <1413299604 dot 9513 dot 53 dot camel at surprise>
Does libgccjit.so end up getting linked with -static-libstdc++
-static-libgcc? If so, that could be problematic (are static libstdc++
and libgcc necessarily built as PIC so it's even possible to embed them
into a shared library?). It's certainly not clear that the
-static-libstdc++ -static-libgcc default for building the compiler
executables is the right one for building libgccjit.so.
The dump file handling appears to have no I/O error checking (no checking
for error on fopen, nothing obvious to prevent fwrite to a NULL m_file if
fopen did have an error, no checking for error on fclose (or fwrite)).
--
Joseph S. Myers
joseph@codesourcery.com