This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PARCH 1/2, x86, PR63534] Fix darwin bootstrap


On Oct 17, 2014, at 7:08 AM, Evgeny Stupachenko <evstupac@gmail.com> wrote:
> The patch fixes 1st fail in darwin bootstarp.
> When PIC register is pseudo we don't need to init it after setjmp or
> non local goto.
> 
> Is it ok?

So, I don’t see commentary in the PR that all fallout and all bugs introduced are fixed by the patch.  :-(

Given how central pic is to code-gen, I don’t favor any patch, until all bugs and regressions are fixed.  If they can’t be, then I favor reversion of the patch that broke everything.

Additionally, if given the types of changes to codegen, I’d like to see the before and after changes to try and ensure that code-gen quality isn’t regressed.  For example, is the pic register saved and restored?  If restored, is the code to save it actually better than simply appearing it out of thin air as did previously?  If the patch that did all the pic work was in one patch, it would be easier for me to see the change in its entirety.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]