This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH i386 AVX512] [80/n] Extend expand_sse2_mulvxdi3.


On Fri, Oct 17, 2014 at 2:32 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
> Hello UroÅ,
> On 16 Oct 14:29, Uros Bizjak wrote:
>> > +         if (mode == V4DImode)
>> > +           emit_insn (gen_avx512dq_mulv4di3 (op0, op1, op2));
>> > +         else if (mode == V2DImode)
>> > +           emit_insn (gen_avx512dq_mulv4di3 (op0, op1, op2));
>>
>> Should this be v2di ?
> Right, copy-and-paste :(
>>
>> > +       }
>> > +    }
>> > +  else if (TARGET_XOP && mode == V2DImode)
>> >      {
>> >        /* op1: A,B,C,D, op2: E,F,G,H */
>> >        op1 = gen_lowpart (V4SImode, op1);
>>
>> Please use function pointers in the added part.
> Done.
>
> Updated patch in the bottom. Is it ok?

OK.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]