This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 AVX512] [63.1/n] Add vpshufb, perm autogen (except for v64qi).
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Tocar <tocarip dot intel at gmail dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 16 Oct 2014 13:15:29 +0200
- Subject: Re: [PATCH i386 AVX512] [63.1/n] Add vpshufb, perm autogen (except for v64qi).
- Authentication-results: sourceware.org; auth=none
- References: <20141006125527 dot GC13369 at msticlxl57 dot ims dot intel dot com> <20141006141035 dot GZ1986 at tucnak dot redhat dot com> <20141009121523 dot GB81768 at msticlxl7 dot ims dot intel dot com> <20141009185105 dot GM1986 at tucnak dot redhat dot com> <20141010154719 dot GA121201 at msticlxl7 dot ims dot intel dot com> <CAFULd4bGehNdNGtZOt+UE50ShHxbL-Xxfv4rNhwPD1sByDjyag at mail dot gmail dot com> <20141016102316 dot GA30455 at msticlxl7 dot ims dot intel dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Thu, Oct 16, 2014 at 02:23:16PM +0400, Ilya Tocar wrote:
> On 10 Oct 18:37, Uros Bizjak wrote:
> > On Fri, Oct 10, 2014 at 5:47 PM, Ilya Tocar <tocarip.intel@gmail.com> wrote:
> >
> >
> > Please recode that horrible first switch statement to:
> >
> > --cut here--
> > rtx (*gen) (rtx, rtx, rtx, rtx) = NULL;
> >
> > switch (mode)
> > {
> > case V8HImode:
> > if (TARGET_AVX512VL && TARGET_AVX152BW)
> > gen = gen_avx512vl_vpermi2varv8hi3;
> > break;
> >
> > ...
> >
> > case V2DFmode:
> > if (TARGET_AVX512VL)
> > {
> > gen = gen_avx512vl_vpermi2varv2df3;
> > maskmode = V2DImode;
> >
> > The patch is OK with the above improvement.
> >
> > Thanks,
> > Uros.
> >
>
> Will commit version below, if no objections in 24 hours.
No need to wait, it is ok now (with proper ChangeLog of course).
Jakub