This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH, Pointer Bounds Checker 14/x] Passes [1/n] Expand interfaces
- From: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 15 Oct 2014 21:54:57 +0400
- Subject: Re: [PATCH, Pointer Bounds Checker 14/x] Passes [1/n] Expand interfaces
- Authentication-results: sourceware.org; auth=none
- References: <20141008185054 dot GA13454 at msticlxl57 dot ims dot intel dot com> <543C400E dot 1050706 at redhat dot com>
2014-10-14 1:11 GMT+04:00 Jeff Law <email@example.com>:
> On 10/08/14 12:50, Ilya Enkovich wrote:
>> This patch starts a series which is a result of split of Pointer Bounds
>> Checker patch #14 (Pointer Bounds Checker passes).
>> This patch introduces compiler flags used by checker and helper functions
>> mostly used by expand pass.
>> 2014-10-08 Ilya Enkovich <firstname.lastname@example.org>
>> * tree-chkp.c: New.
>> * tree-chkp.h: New.
>> * rtl-chkp.c: New.
>> * rtl-chkp.h: New.
>> * Makefile.in (OBJS): Add rtl-chkp.o and tree-chkp.o.
>> (GTFILES): Add tree-chkp.c.
>> * c-family/c.opt (fchkp-check-incomplete-type): New.
>> (fchkp-zero-input-bounds-for-main): New.
>> (fchkp-first-field-has-own-bounds): New.
>> (fchkp-narrow-bounds): New.
>> (fchkp-narrow-to-innermost-array): New.
>> (fchkp-optimize): New.
>> (fchkp-use-fast-string-functions): New.
>> (fchkp-use-nochk-string-functions): New.
>> (fchkp-use-static-bounds): New.
>> (fchkp-use-static-const-bounds): New.
>> (fchkp-treat-zero-dynamic-size-as-infinite): New.
>> (fchkp-check-read): New.
>> (fchkp-check-write): New.
>> (fchkp-store-bounds): New.
>> (fchkp-instrument-calls): New.
>> (fchkp-instrument-marked-only): New.
>> * cppbuiltin.c (define_builtin_macros_for_compilation_flags): Add
>> __CHKP__ macro when Pointer Bounds Checker is on.
> OK for the trunk.
> So at this point do we have any patches that have not been reviewed for this
> stage of the bounded pointers work? Are there any which you have posted
> updated versions that you feel need further review?
Thanks for review! I see no more patches not reviewed at all. I see
4 more patches requiring approve before I can start a merge.
Two of them are parts of split #14 (Passes): #14.3 (Helper functions)
and #14.16 (Reduce bounds lifetime)
There is also #32 (hooks for i386 target). It has concern about TBAA
which I believe is not a problem in my case because accesses using
different types are not mixed.
The final one is #33 (MPX ABI). I still see fail on one benchmark but
I don't feel ICE in LRA should prevent patch from been committed.