This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 7/n] OpenMP 4.0 offloading infrastructure: testsuite


On Wed, Oct 15, 2014 at 06:57:52PM +0400, Ilya Verbin wrote:
> Hello,
> 
> This patch adds all examples with '#pragma omp target' from [1] to libgomp
> testsuite.  Without an accelerator or emulator, these tests are UNSUPPORTED.

Why?  Most of the tests should work just fine with host fallback.
Yeah, from Examples 4.0.1 I'm aware of some tests which assume that host
fallback doesn't happen, but they should be in minority.
So, can you temporarily change check_effective_target_offload_device to
always return 0 from main, run the testsuite with OMP_DEFAULT_DEVICE=10000
in the environment and see what testcases really need
{ dg-require-effective-target offload_device } ?

Also, can you please use in C tests normal /* ... */ comments instead of
C++ comments for dg-* directive lines?

Otherwise LGTM.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]