This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR lto/61048 Define missed builtins on demand
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Ilya Palachev <i dot palachev at samsung dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Vyacheslav Barinov <v dot barinov at samsung dot com>
- Date: Wed, 15 Oct 2014 08:59:19 +0200
- Subject: Re: [PATCH] PR lto/61048 Define missed builtins on demand
- Authentication-results: sourceware.org; auth=none
- References: <543D51CC dot 6050202 at samsung dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Oct 14, 2014 at 08:39:40PM +0400, Ilya Palachev wrote:
> Attached patch fixes PR lto/61048 -
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61048
Given that the patch just replaces an ICE with a necessary link failure, I'd say
it is done at the wrong place, instead during the LTO option handling you
should error out if there are incompatibilities in -fsanitize options
(any object compiled with flag_sanitize & SANITIZE_USER_ADDRESS, but
link done without that, ditto for SANITIZE_KERNEL_ADDRESS, SANITIZE_THREAD.
And finally if flag_sanitize & (SANITIZE_UNDEFINED | SANITIZE_NONDEFALT)
is non-zero but during linking it is zero (it doesn't really matter which
exact undefined sanitization options are used at what time).
BTW, in your patches please watch formatting, you didn't use space before (.
Jakub