This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/2] Fix ILP32 ld.so.


On 08/08/2014 08:51 PM, Andrew Pinski wrote:
> ChangeLog:
> 	* explow.c (convert_memory_address_addr_space): Rename to ...
> 	(convert_memory_address_addr_space_1): This.  Add in_const argument.
> 	Inside a CONST RTL, permute the conversion and addition of constant
> 	for zero and sign extended pointers.
> 	(convert_memory_address_addr_space): New function.

Ok, with one nit...

> +	      && ((in_const && POINTERS_EXTEND_UNSIGNED !=0)

Missing space after !=


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]