This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 2/2] Fix ILP32 ld.so.
- From: Richard Henderson <rth at redhat dot com>
- To: Andrew Pinski <apinski at cavium dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 14 Oct 2014 11:37:17 -0700
- Subject: Re: [PATCH 2/2] Fix ILP32 ld.so.
- Authentication-results: sourceware.org; auth=none
- References: <1407556266-12337-1-git-send-email-apinski at cavium dot com> <1407556266-12337-3-git-send-email-apinski at cavium dot com>
On 08/08/2014 08:51 PM, Andrew Pinski wrote:
> ChangeLog:
> * explow.c (convert_memory_address_addr_space): Rename to ...
> (convert_memory_address_addr_space_1): This. Add in_const argument.
> Inside a CONST RTL, permute the conversion and addition of constant
> for zero and sign extended pointers.
> (convert_memory_address_addr_space): New function.
Ok, with one nit...
> + && ((in_const && POINTERS_EXTEND_UNSIGNED !=0)
Missing space after !=
r~