This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, i386, Pointer Bounds Checker 38/x] Avoid warning for missed IPA_REF_CHKP in switch


On 02 Oct 15:34, Marek Polacek wrote:
> On Thu, Oct 02, 2014 at 05:29:15PM +0400, Ilya Enkovich wrote:
> > Hi,
> > 
> > Seems some new warnings appeared lately and now I see a bootstrap failure for mpx branch due to missing IPA_REF_CHKP case in switch statement in process_references function.  This function handles varpool_nodes which cannot have references of this kind.  This patch fixes a warning.
> 
> Yeah, -Wswitch now works even with enum bit-fields, and use in ipa_ref
> is an enum bit-fields.
> 
> > 2014-10-01  Ilya Enkovich  <ilya.enkovich@intel.com>
> > 
> > 	* ipa.c (process_references): Support IPA_REF_CHKP.
>  
> Probably s/Support/Handle/.
>  
> > diff --git a/gcc/ipa.c b/gcc/ipa.c
> > index 39ee815..78f251a 100644
> > --- a/gcc/ipa.c
> > +++ b/gcc/ipa.c
> > @@ -637,6 +637,8 @@ process_references (varpool_node *vnode,
> >  	process_references (dyn_cast<varpool_node *> (ref->referring), written,
> >  			    address_taken, read, explicit_refs);
> >  	break;
> > +      case IPA_REF_CHKP:
> > +	gcc_unreachable ();
> 
> Looks ok.
> 
> 	Marek

Thanks for looking inot it.  Here is a version with modified ChangeLog.

Ilya
--
2014-10-02  Ilya Enkovich  <ilya.enkovich@intel.com>

	* ipa.c (process_references): Handle IPA_REF_CHKP.


diff --git a/gcc/ipa.c b/gcc/ipa.c
index 39ee815..78f251a 100644
--- a/gcc/ipa.c
+++ b/gcc/ipa.c
@@ -637,6 +637,8 @@ process_references (varpool_node *vnode,
 	process_references (dyn_cast<varpool_node *> (ref->referring), written,
 			    address_taken, read, explicit_refs);
 	break;
+      case IPA_REF_CHKP:
+	gcc_unreachable ();
       }
 }
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]