This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Bug libstdc++/62313] Data race in debug iterators
- From: Jonathan Wakely <jwakely at redhat dot com>
- To: François Dumont <frs dot dumont at gmail dot com>
- Cc: "libstdc++ at gcc dot gnu dot org" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 1 Oct 2014 13:13:37 +0100
- Subject: Re: [Bug libstdc++/62313] Data race in debug iterators
- Authentication-results: sourceware.org; auth=none
- References: <bug-62313-19885 at http dot gcc dot gnu dot org/bugzilla/> <bug-62313-19885-GBoNocJyMm at http dot gcc dot gnu dot org/bugzilla/> <5410BAB5 dot 90803 at gmail dot com> <20140921220411 dot GD22778 at redhat dot com> <5421DB37 dot 8080307 at gmail dot com> <54249096 dot 5020408 at gmail dot com> <20140926100510 dot GJ2669 at redhat dot com> <20140930153241 dot GK4197 at redhat dot com> <542B1010 dot 3030301 at gmail dot com>
On 30/09/14 22:18 +0200, François Dumont wrote:
Hi
I prefer to submit this patch to you cause I am not very
comfortable with Python stuff.
I simply rely on Python cast feature. It doesn't really matter but
is it going to simply consider the debug iterator as a normal one or
Yes.
is it going through the C++ explicit cast operator on debug iterators
?
No, it doesn't call any C++ function.
(N.B. I was searching in debug/safe_iterator.h for the 'explicit'
conversion operator you referred to and was confused because I
couldn't find it, which is because the operator for converting to base
is not 'explicit')
I'm not sure why the existing Python code does .cast(itype) when
_M_current is already that type, that seems unnecessary to me, but
I think your fix is correct and OK to commit, thanks.