This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] Add CO_BROADCAST
- From: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- To: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Date: Mon, 29 Sep 2014 16:31:57 +0200
- Subject: Re: [Patch, Fortran] Add CO_BROADCAST
- Authentication-results: sourceware.org; auth=none
- References: <20140927110702 dot 59342100 at mailhost dot lps dot ens dot fr> <20140929081704 dot GA11532 at physik dot fu-berlin dot de>
On Mon, Sep 29, 2014 at 10:17:04AM +0200, Tobias Burnus wrote:
> Dominique Dhumieres wrote:
> > The failures for the gfortran.dg/coarray_collectives_9.f90 are fixed
> > with the following patch:
>
> Looks good to me. The patch is OK with a ChangLog.
Actually, I missed the following part:
...
- call co_broadcasr(vec(idx), 1) ! { dg-error "Argument 'A' with INTENT\\(INOUT\\) at .1. of the intrinsic subroutine co_sum shall not have a vector subscript" }
- call co_reduce(vec([1,3,2]), red_f) ! { dg-error "Argument 'A' with INTENT\\(INOUT\\) at .1. of the intrinsic subroutine co_min shall not have a vector subscript" }
+ call co_broadcasr(vec(idx), 1) ! OK?
...
Which is not fully okay: The error message should stay - but the
procedure name should (...casr) should be corrected (...cast).
Tobias
PS: I think I will soon post a patch to support Fortran 2015's
"IMPLICIT NONE (....)" where ... can be is an implicit-none list with
values TYPE and EXTERNAL. Because a "implicit none (type, external)"
would have found the typo! (Or likewise: -Wimplicit-procedure.)