This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR63266: Keep track of impact of sign extension in bswap
- From: Christophe Lyon <christophe dot lyon at linaro dot org>
- To: "Thomas Preud'homme" <thomas dot preudhomme at arm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 26 Sep 2014 18:12:04 +0200
- Subject: Re: [PATCH] Fix PR63266: Keep track of impact of sign extension in bswap
- Authentication-results: sourceware.org; auth=none
- References: <000001cfd198$71470e30$53d52a90$ at arm dot com> <CAFiYyc12bCCxtunYgib+kPvY7-R=ygiw0sBY-bPz=V7NkqPRyQ at mail dot gmail dot com> <CAKdteOZOJp6dA9FVYuX_Nmwo9JQZkSh0yERAr5Wg8cn3w0WXYA at mail dot gmail dot com> <002b01cfd88b$76644410$632ccc30$ at arm dot com> <CAKdteOaJc6qgWZXBa-wb3WSKKrASZP8CuKG8MzEP2MdQ+JR2ew at mail dot gmail dot com> <002c01cfd931$1a684660$4f38d320$ at arm dot com>
On 26 September 2014 04:25, Thomas Preud'homme
<thomas.preudhomme@arm.com> wrote:
>> From: Christophe Lyon [mailto:christophe.lyon@linaro.org]
>> Sent: Thursday, September 25, 2014 10:08 PM
>>
>
>> While attempting to try this, I noticed that more precisely the test
>> is currently UNSUPPORTED on aarch64_be,
>> which is because check_effective_target_bswap only accepts istarget
>> aarch64-*-*.
>
> Ah yes, of course.
>
>>
>> I didn't try yet to change it into istarget aarch64*-*-*.
>
> It should probably be added no matter the result anyway, since this target has bswap instructions.
>
Fixing check_effective_target_bswap to accept aarch64*-*-* makes the
test pass, so we should submit that patch.
I tried the other change you suggested, but it seem that
scan-tree-dump-times only matched 3 times. I did this in a bit of a
hurry though, so I may have done something wrong.
I'm not sure when I have time to look at that again, so I prefer to
give this little feedback now :-)
Christophe.
> Best regards,
>
> Thomas
>
>
>