This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge

From: Jeff Law <law at redhat dot com>
To: Jiong Wang <jiong dot wang at arm dot com>, Zhenqiang Chen <Zhenqiang dot Chen at arm dot com>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 22 Sep 2014 11:51:13 -0600
Subject: Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
Authentication-results: sourceware.org; auth=none
References: <CACgzC7AJUvPr_uQpMq7zS_570TKAqe12vp1T=D2s=7xUmmh6dA at mail dot gmail dot com> <54170583 dot 4040002 at arm dot com> <000001cfd17b$25ec75f0$71c561d0$ at arm dot com> <541BC46F dot 8050401 at redhat dot com> <541C131B dot 7080805 at arm dot com> <541C50A0 dot 9050807 at redhat dot com> <541C53B2 dot 1020007 at arm dot com> <541C578E dot 9080606 at redhat dot com> <541FF8D2 dot 2070807 at arm dot com>

On 09/22/14 04:24, Jiong Wang wrote:

Great.  Can you send an updated patchkit for review.


patch attached.

please review, thanks.

gcc/ * shrink-wrap.c (move_insn_for_shrink_wrap): Initialize the
live-in of new created BB as the intersection of live-in from
"old_dest" and live-out from "bb".

Looks good.  However, before committing we need a couple things.

1. Bootstrap & regression test this variant of the patch. I know youtested an earlier one, but please test this one just to be sure.

2. Testcase. I think you could test for either the reduction in thelive-in set of the newly created block or that you're shrink wrappingone or more functions you didn't previously shrink-wrap. I think it'sfine if this test is target specific.


Jeff

Follow-Ups:
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jiong Wang

References:
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jiong Wang
- RE: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Zhenqiang Chen
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jeff Law
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jiong Wang
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jeff Law
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jiong Wang
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jeff Law
- Re: [PATCH, 2/2] shrink wrap a function with a single loop: split live_edge
  - From: Jiong Wang

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]