This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Do not remove labels with LABEL_PRESERVE_P

From: Jeff Law <law at redhat dot com>
To: Ilya Enkovich <enkovich dot gnu at gmail dot com>, gcc-patches at gcc dot gnu dot org
Date: Fri, 19 Sep 2014 14:03:24 -0600
Subject: Re: [PATCH] Do not remove labels with LABEL_PRESERVE_P
Authentication-results: sourceware.org; auth=none
References: <20140919193604 dot GA48001 at msticlxl57 dot ims dot intel dot com>

On 09/19/14 13:36, Ilya Enkovich wrote:

Hi,

During my work on enabling pseudo PIC register I've found that cfg cleaunp may remove lables with LABEL_PRESERVE_P set to 1.  In my case I generated SET_RIP during expand pass and cfg cleanup removed label it used as an operand.  Below is a patch that fixes it.  It is not actually required for our latest PIC related patch but still seems to make sense.

Bootstrapped and tested on linux-x86_64.

Thanks,
Ilya
--
2014-09-19  Ilya Enkovich  <ilya.enkovich@intel.com>

	* cfgcleanup.c (try_optimize_cfg): Do not remove label
	with LABEL_PRESERVE_P flag set.

OK.  Please install.

Note for those not following the x86 32 bit PIC register discussion, Iasked Ilya to submit this separately. It was something an earlierversion of his patch triggered and it stood out as something that oughtto be fixed regardless of the final form of the PIC register changesthat are in progress.



Thanks,
Jeff

Follow-Ups:
- Re: [PATCH] Do not remove labels with LABEL_PRESERVE_P
  - From: Steven Bosscher

References:
- [PATCH] Do not remove labels with LABEL_PRESERVE_P
  - From: Ilya Enkovich

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]