This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH i386 AVX512] [37/n] Extend max/min insn patterns.
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Uros Bizjak <ubizjak at gmail dot com>
- Cc: Kirill Yukhin <kirill dot yukhin at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>, Richard Henderson <rth at redhat dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 11 Sep 2014 11:21:34 -0700
- Subject: Re: [PATCH i386 AVX512] [37/n] Extend max/min insn patterns.
- Authentication-results: sourceware.org; auth=none
- References: <20140911130050 dot GB62005 at msticlxl57 dot ims dot intel dot com> <CAFULd4aK1KSeOk9D75t2WHsUvwCRA0rTewPPuRDNKtaxRxSjDA at mail dot gmail dot com>
On Thu, Sep 11, 2014 at 11:10 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
> On Thu, Sep 11, 2014 at 3:00 PM, Kirill Yukhin <kirill.yukhin@gmail.com> wrote:
>
>> Patch in the bottom extends integer max/min patterns.
>> Also, it seems, like rounding variant was generated
>> for maxmin patterns. Bug fixed.
>>
>> Bootstrapped.
>> AVX-512* tests on top of patch-set all pass
>> under simulator.
>>
>> Is it ok for trunk?
>>
>> gcc/
>> * config/i386/sse.md (VI128_256): Delete.
>> (define_mode_iterator VI124_256): New.
>> (define_mode_iterator VI124_256_AVX512F_AVX512BW): Ditto.
>> (define_expand "<code><mode>3<mask_name><round_name>"): Delete.
>> (define_expand "<code><VI124_256_AVX512F_AVX512BW:mode>3"): New.
>> (define_insn "*avx2_<code><VI124_256:mode>3"): Rename from
>> "*avx2_<code><mode>3<mask_name><round_name>" and update mode iterator.
>> (define_expand "<code><VI48_AVX512VL:mode>3_mask"): New.
>> (define_insn "*avx512bw_<code><VI48_AVX512VL:mode>3<mask_name>"): Ditto.
>> (define_insn "<mask_codefor><code><mode>3<mask_name>"): Update mode
>> iterator.
>> (define_expand "<code><mode:VI8_AVX2>3"): Update pettern generation
>
> "<code><VI8_AVX2:mode>3"
>
>> in presence of AVX-512.
>
> The patch is OK.
>
> (BTW: Sometimes "svn diff -x -upw" comes handy to exclude whitespace
> changes. I don't know the equivalent option for git, though.)
>
git diff -w
-w, --ignore-all-space
Ignore whitespace when comparing lines. This ignores
differences even if one
line has whitespace where the other line has none.
--
H.J.