On Thu, Sep 11, 2014 at 6:06 PM, Bernd Schmidt wrote:
On 09/11/2014 05:55 PM, Steven Bosscher wrote:
On Thu, Sep 11, 2014 at 3:26 PM, Bernd Schmidt wrote:
nvptx will be the first port to use BImode and have STORE_FLAG_VALUE==-1.
That has exposed a bug in combine where we can end up calling
num_sign_bit_copies for a BImode value. However, the return value is
always
1 in that case, so it doesn't tell us anything and is going to be
misinterpreted by the caller.
Bootstrapped and tested on x86_64-linux, together with the other patches.
Ok?
This should be handled in num_sign_bit_copies itself, i.e. handle BImode
there.
What do you expect that function to do different? It returns the correct
value.
No different. Just that if you want to check whether DECL is a global
variable then we have a predicate for it. So why use TREE_STATIC
instead?
In other words: Just trying to make/keep certain checks consistent. (A
hopeless cause, but a noble one... ;-)