This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction

From: Alan Lawrence <alan dot lawrence at arm dot com>
To: Christophe Lyon <christophe dot lyon at linaro dot org>
Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 08 Sep 2014 17:12:13 +0100
Subject: Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction
Authentication-results: sourceware.org; auth=none
References: <53F32A86 dot 4060109 at arm dot com> <CAFqB+PxGMAULr7Z9OW6N2VUXxNEBVqhB5TU6b-RzT-4DXAOYaA at mail dot gmail dot com> <CAKdteOYHb4kHW11y99t=5uxSX2GqhAhxmr3L4UG8Q2hx0fJoyw at mail dot gmail dot com>

Hmmm, thanks for the heads-up. Now reproduced. Looks like a TCL regexp issue,
should have a fix shortly.

Cheers,
--Alan

Christophe Lyon wrote:

Hi Alan,

In my cross-testing I've noticed that your new test:
gcc.target/aarch64/simd/int_comparisons_1.c scan-assembler-not not
is PASS for targets aarch64-none-elf and aarch64_be-none-elf, but
FAIL for aarch64-none-linux-gnu.

It seems this is not what you saw in your own validations?

Christophe.



On 2 September 2014 17:17, Marcus Shawcroft <marcus.shawcroft@gmail.com> wrote:

On 19 August 2014 11:44, Alan Lawrence <alan.lawrence@arm.com> wrote:

gcc/ChangeLog:

        * config/aarch64/aarch64-builtins.c (aarch64_types_cmtst_qualifiers,
        TYPES_TST): Define.
        (aarch64_fold_builtin): Update pattern for cmtst.

        * config/aarch64/aarch64-protos.h
(aarch64_const_vec_all_same_int_p):
        Declare.

        * config/aarch64/aarch64-simd-builtins.def (cmtst): Update
qualifiers.

        * config/aarch64/aarch64-simd.md
(aarch64_vcond_internal<mode><mode>):
        Switch operands, separate out more cases, refactor.

        (aarch64_cmtst<mode>): Rewrite pattern to match (plus ... -1).

        * config/aarch64.c (aarch64_const_vec_all_same_int_p): Take single
        argument; rename old version to...
        (aarch64_const_vec_all_same_in_range_p): ...this.
        (aarch64_print_operand, aarch64_simd_shift_imm_p): Follow renaming.

        * config/aarch64/predicates.md (aarch64_simd_imm_minus_one): Define.

gcc/testsuite/ChangeLog:

        * gcc.target/aarch64/simd/int_comparisons.x: New file.
        * gcc.target/aarch64/simd/int_comparisons_1.c: New test.
        * gcc.target/aarch64/simd/int_comparisons_2.c: Ditto.

OK /Marcus

References:
- Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction
  - From: Marcus Shawcroft
- Re: [PATCH AArch64 1/2] Improve codegen of vector compares inc. tst instruction
  - From: Christophe Lyon

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]