This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr
- From: Tom Tromey <tom at tromey dot com>
- To: Siva Chandra <sivachandra at google dot com>
- Cc: Tom Tromey <tom at tromey dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, Jonathan Wakely <jwakely dot gcc at gmail dot com>
- Date: Thu, 28 Aug 2014 11:15:04 -0600
- Subject: Re: [PATCH libstdc++ v5] - Add xmethods for std::vector and std::unique_ptr
- Authentication-results: sourceware.org; auth=none
- References: <CAGyQ6gxAYwoi3gLkH-Ut_qRfHpTbV0Dke+bd9BRk_e7cWj4nOA at mail dot gmail dot com> <87y4u95zv9 dot fsf at tromey dot com> <CAGyQ6gzTNQvpiqC_Jzt_kkAUeCH34pA5FF8m-_w-RWJ5w1YutQ at mail dot gmail dot com> <87tx4x5z6u dot fsf at tromey dot com> <CAGyQ6gxDzDAs6L59ggh70n_OPWBDOoMubtOKjHP1Y6OCMdc2Mg at mail dot gmail dot com> <87ha0x5pnq dot fsf at tromey dot com> <CAGyQ6gy-KmHN2rUaPtMXypxJS3kwKp8-mT_SUELiv0rwWGy0Hg at mail dot gmail dot com>
>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:
Tom> Yeah, that's my view.
Siva> I am probably not understanding it right again.
It's ok. I am having some trouble myself.
Siva> Are you suggesting that in hook.in, we just have single function
Siva> call like this:
Siva> register_python_hooks (gdb.current_objfile ())
Siva> and, this function register_python_hooks lives somewhere else and
Siva> calls register_libstdcxx_printers and register_libstdcxx_xmethods?
Yeah. I think it's better to put as little as possible in the hook file.
I realize this may sound ridiculous given all the code that is already
there; but that's an artifact of gcc's install-relocatability requirement.
Tom