This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.
- From: Jeff Law <law at redhat dot com>
- To: Chen Gang <gang dot chen dot 5i5j at gmail dot com>, tromey at redhat dot com, aph at redhat dot com, per at bothner dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 30 Jul 2014 22:10:05 -0600
- Subject: Re: [PATCH] libjava/classpath/native/jni/java-lang/java_lang_VMProcess.c: Be sure 'errbuf' always be zero terminated.
- Authentication-results: sourceware.org; auth=none
- References: <53D63F19 dot 4050405 at gmail dot com> <53D7313C dot 8080203 at gmail dot com> <53D908CA dot 3060405 at gmail dot com>
On 07/30/14 09:01, Chen Gang wrote:
I don't think you've have any kind of negative impact. GCC developers
tend to be a bit more conservative and try not to change code just for
the sake of changing code. Thus we tend to want to have a clearer
understanding of why a particular change needs to be made.
I shall stop making this kind of patch, next. The reason is that I worry
about what I have done have negative effect to others. And next, I shall
try to send another kinds of patches for gcc when I have time.
Many persons or companies use open source who never give thanks or
contribution back to open source. But open source (especially,
fundamental software) still provide common contributions to outside.
What I have done is only for contribution back to open source, so I can
understand none-reply from open source (at least, it is not the excuse
to let myself stop). But what I worry about is whether bother others.
It's also the case that we tend to look more closely at patches from
relatively new developers simply because we don't have a long history of
interactions that have built trust over time.
So, just to be clear, I don't think you're bothering anyone and I would
recommend you continue to analyze code and send patches.
And sorry for telling you everything goes to gcc-patches. I often
forget there's a separate java patch list -- and more generally for the
runtime libraries, we're often a downstream code consumer. Thus a
proposed change in some of the runtime libraries may need to be sent to
other projects (Classpath is a good example).