This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] PR61868
- From: Andi Kleen <ak at linux dot intel dot com>
- To: Richard Biener <richard dot guenther at gmail dot com>
- Cc: Bingfeng Mei <bmei at broadcom dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 30 Jul 2014 07:46:32 -0700
- Subject: Re: [PATCH] PR61868
- Authentication-results: sourceware.org; auth=none
- References: <B71DF1153024A14EABB94E39368E44A6042D5AA1 at SJEXCHMB13 dot corp dot ad dot broadcom dot com> <CAFiYyc1ozFqcBjg5dO2R8RzV-4fqd-08KODSoDpeQT11N=P7Zg at mail dot gmail dot com>
On Wed, Jul 30, 2014 at 09:46:48AM +0200, Richard Biener wrote:
> On Tue, Jul 29, 2014 at 3:01 PM, Bingfeng Mei <firstname.lastname@example.org> wrote:
> > Hi,
> > Please find the patches for pr61868. The problem is that even with -frandom-seed gcc always uses 0 instead of specified number/string for places such as lto section names. init_random_seed is never called with -frandom-seed. Bootstrapped and tested on x86-64. OK for trunk?
> Hmm, but -frandom-seed= is honored by opts.c calling set_random_seed?
> Andi, wasn't this used to support partial linking of LTO objects? Thus,
> this shortcut was on purpose? Otherwise passing -frandom-seed to
> LTO would break that?
I don't think it was on purpose. Partial linking doesn't need
the seeds. The seeding was only to avoid compare failures in
the gcc build.